fix: audit remediation — security, quality and performance fixes
Update PKGBUILD version / update-pkgver (push) Successful in 3s
Update PKGBUILD version / update-pkgver (push) Successful in 3s
- CI Dockerfile: verify act_runner SHA256, restrict sudoers to safe pacman arguments (S-C1, S-C2) - cliphist: split into cliphist-text + cliphist-image services with Type=simple for proper PID tracking and restart (Q-C3) - batsaver-toggle: validate sysfs input as numeric, check state file write (Q-C2, S-W2) - udev battery rule: add ACTION=="add" filter to avoid firing on every battery event (Q-W3) - cpugov: replace eval with direct expansion, switch waybar module to signal-based updates, send SIGRTMIN+10 after toggle (Q-W1, S-W1, P-W4) - Remove docker group auto-assignment from install scripts (S-I1)
This commit is contained in:
@@ -10,6 +10,7 @@ CONSERVATION_LIMIT=80
|
||||
[[ -f "$THRESHOLD_FILE" ]] || exit 1
|
||||
|
||||
CURRENT=$(cat "$THRESHOLD_FILE")
|
||||
[[ "$CURRENT" =~ ^[0-9]+$ ]] || exit 1
|
||||
|
||||
if [[ "$CURRENT" -le "$CONSERVATION_LIMIT" ]]; then
|
||||
NEW=100
|
||||
@@ -22,7 +23,7 @@ echo "$NEW" > "$THRESHOLD_FILE" || exit 1
|
||||
|
||||
# Persist for next boot
|
||||
mkdir -p "$STATE_DIR"
|
||||
echo "$NEW" > "$STATE_FILE"
|
||||
echo "$NEW" > "$STATE_FILE" || exit 1
|
||||
|
||||
# Signal Waybar to refresh the batsaver module (SIGRTMIN+9)
|
||||
pkill -RTMIN+9 waybar
|
||||
|
||||
@@ -60,11 +60,12 @@ fi
|
||||
# check if choice exists
|
||||
if test "${COMMANDS[$choice]+isset}"
|
||||
then
|
||||
# Execute the choice — eval required because COMMANDS values contain
|
||||
# multi-word strings that must be interpreted as full commands.
|
||||
eval "${COMMANDS[$choice]}"
|
||||
${COMMANDS[$choice]}
|
||||
|
||||
notify-send -h string:x-canonical-private-synchronous:cpugov -i cpu "CPU Mode" "Set to $choice ${LABELS[$choice]}"
|
||||
|
||||
# Signal Waybar to refresh the cpugov module (SIGRTMIN+10)
|
||||
pkill -RTMIN+10 waybar
|
||||
else
|
||||
notify-send -u critical "CPU Governor" "Unknown command: ${choice}"
|
||||
fi
|
||||
|
||||
@@ -0,0 +1,16 @@
|
||||
# ABOUTME: systemd user service for image clipboard history via cliphist + wl-paste.
|
||||
# ABOUTME: Stores image clipboard entries in XDG_RUNTIME_DIR.
|
||||
|
||||
[Unit]
|
||||
Description=Clipboard history manager (image)
|
||||
PartOf=graphical-session.target
|
||||
After=cliphist-text.service
|
||||
|
||||
[Service]
|
||||
Type=simple
|
||||
ExecStart=/usr/bin/wl-paste --type image --watch cliphist -db-path %t/cliphist/db store
|
||||
Restart=on-failure
|
||||
RestartSec=3
|
||||
|
||||
[Install]
|
||||
WantedBy=graphical-session.target
|
||||
@@ -0,0 +1,17 @@
|
||||
# ABOUTME: systemd user service for text clipboard history via cliphist + wl-paste.
|
||||
# ABOUTME: Wipes history on start, stores text entries in XDG_RUNTIME_DIR.
|
||||
|
||||
[Unit]
|
||||
Description=Clipboard history manager (text)
|
||||
PartOf=graphical-session.target
|
||||
After=graphical-session.target
|
||||
|
||||
[Service]
|
||||
Type=simple
|
||||
ExecStartPre=/bin/sh -c 'mkdir -p $XDG_RUNTIME_DIR/cliphist && /usr/bin/cliphist wipe'
|
||||
ExecStart=/usr/bin/wl-paste --watch cliphist -db-path %t/cliphist/db store
|
||||
Restart=on-failure
|
||||
RestartSec=3
|
||||
|
||||
[Install]
|
||||
WantedBy=graphical-session.target
|
||||
@@ -1,16 +0,0 @@
|
||||
# ABOUTME: systemd user service for clipboard history (cliphist + wl-paste).
|
||||
# ABOUTME: Stores text and image clipboard entries, wipes history on session end.
|
||||
|
||||
[Unit]
|
||||
Description=Clipboard history manager
|
||||
PartOf=graphical-session.target
|
||||
After=graphical-session.target
|
||||
|
||||
[Service]
|
||||
Type=forking
|
||||
ExecStartPre=/usr/bin/cliphist wipe
|
||||
ExecStart=/bin/sh -c 'mkdir -p $XDG_RUNTIME_DIR/cliphist && wl-paste --watch cliphist -db-path $XDG_RUNTIME_DIR/cliphist/db store & wl-paste --type image --watch cliphist -db-path $XDG_RUNTIME_DIR/cliphist/db store &'
|
||||
RemainAfterExit=yes
|
||||
|
||||
[Install]
|
||||
WantedBy=graphical-session.target
|
||||
@@ -1,4 +1,4 @@
|
||||
# ABOUTME: udev rule granting wheel group write access to battery charge threshold.
|
||||
# ABOUTME: Enables unprivileged toggling of conservation mode via moonarch-batsaver-toggle.
|
||||
|
||||
SUBSYSTEM=="power_supply", ATTR{type}=="Battery", RUN+="/bin/sh -c 'chgrp wheel /sys%p/charge_control_end_threshold 2>/dev/null; chmod g+w /sys%p/charge_control_end_threshold 2>/dev/null'"
|
||||
SUBSYSTEM=="power_supply", ACTION=="add", ATTR{type}=="Battery", RUN+="/bin/sh -c 'chgrp wheel /sys%p/charge_control_end_threshold 2>/dev/null; chmod g+w /sys%p/charge_control_end_threshold 2>/dev/null'"
|
||||
|
||||
@@ -296,7 +296,8 @@
|
||||
"custom/cpugov": {
|
||||
"exec": "moonarch-waybar-cpugov",
|
||||
"return-type": "json",
|
||||
"interval": 5,
|
||||
"interval": 60,
|
||||
"signal": 10,
|
||||
"on-click": "moonarch-cpugov"
|
||||
},
|
||||
"custom/gpu-usage": {
|
||||
|
||||
Reference in New Issue
Block a user