ci: add update-pkgver workflow (tag-trigger)

led accepted any u16 and main.rs clamped to 0..=1000 with no feedback,
inconsistent with sidetone which rejects out-of-range at parse time.
Add a clap range validator (0..=1000) and drop the silent clamp, so
invalid input now fails loudly.

Further quality-audit follow-ups:
- remove dead BragiDevice::open() (no caller; binary uses open_with_verbose)
- add tests: led range validation, format_battery for all status
  variants, waybar "unknown" class

Bump 0.1.2 -> 0.1.3.

.gitea/workflows/update-pkgver.yaml

@@ -0,0 +1,43 @@
+# ABOUTME: Updates pkgver in moonarch-pkgbuilds when a new corsairctl tag is pushed.
+# ABOUTME: Reads the latest version tag and bumps the PKGBUILD + .SRCINFO.
+
+name: Update PKGBUILD version
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+jobs:
+  update-pkgver:
+    runs-on: moonarch
+    steps:
+      - name: Determine pkgver from latest tag
+        run: |
+          git clone --bare http://gitea:3000/nevaforget/corsairctl.git source.git
+          cd source.git
+          PKGVER=$(git describe --tags --abbrev=0 | sed 's/^v//')
+          echo "New pkgver: $PKGVER"
+          echo "$PKGVER" > /tmp/pkgver
+
+      - name: Update PKGBUILD
+        run: |
+          PKGVER=$(cat /tmp/pkgver)
+          git clone http://gitea:3000/nevaforget/moonarch-pkgbuilds.git pkgbuilds
+          cd pkgbuilds
+
+          OLD_VER=$(grep '^pkgver=' corsairctl/PKGBUILD | cut -d= -f2)
+          if [ "$OLD_VER" = "$PKGVER" ]; then
+            echo "pkgver already up to date ($PKGVER)"
+            exit 0
+          fi
+
+          sed -i "s/^pkgver=.*/pkgver=$PKGVER/" corsairctl/PKGBUILD
+          sed -i "s/^\tpkgver = .*/\tpkgver = $PKGVER/" corsairctl/.SRCINFO
+          echo "Updated pkgver: $OLD_VER → $PKGVER"
+
+          git config user.name "pkgver-bot"
+          git config user.email "gitea@moonarch.de"
+          git add corsairctl/PKGBUILD corsairctl/.SRCINFO
+          git commit -m "chore(corsairctl): bump pkgver to $PKGVER"
+          git -c http.extraHeader="Authorization: token ${{ secrets.PKGBUILD_TOKEN }}" push

Cargo.lock

@@ -144,7 +144,7 @@ checksum = "1d07550c9036bf2ae0c684c4297d503f838287c83c53686d05370d0e139ae570"
 
 [[package]]
 name = "corsairctl"
-version = "0.1.2"
+version = "0.1.3"
 dependencies = [
  "alsa",
  "clap",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "corsairctl"
-version = "0.1.2"
+version = "0.1.3"
 edition = "2024"
 description = "CLI tool for Corsair Bragi-protocol devices (HS80, etc.)"
 license = "MIT"

src/bragi/device.rs

@@ -22,11 +22,7 @@ pub struct BragiDevice {
 
 impl BragiDevice {
     /// Findet ein Corsair-Gerät, öffnet es und führt die Init-Sequenz durch.
-    pub fn open() -> Result<Self> {
+    /// Mit optionalem Debug-Output auf stderr.
-        Self::open_with_verbose(false)
-    }
-
-    /// Wie `open()`, aber mit optionalem Debug-Output auf stderr.
     pub fn open_with_verbose(verbose: bool) -> Result<Self> {
         let api = HidApi::new()?;
         if verbose {

src/cli.rs

@@ -29,6 +29,7 @@ pub enum Command {
     /// LED-Helligkeit lesen oder setzen (0-1000)
     Led {
         /// Helligkeit (0-1000). Ohne Angabe wird der aktuelle Wert gelesen.
+        #[arg(value_parser = clap::value_parser!(u16).range(0..=1000))]
         brightness: Option<u16>,
     },
 

src/main.rs

@@ -33,9 +33,8 @@ fn run() -> error::Result<()> {
         Command::Led { brightness } => {
             let device = bragi::BragiDevice::open_with_verbose(cli.verbose)?;
             if let Some(value) = brightness {
-                let clamped = value.clamp(0, 1000);
+                device.set_brightness(value)?;
-                device.set_brightness(clamped)?;
+                println!("{}", output::format_brightness(value));
-                println!("{}", output::format_brightness(clamped));
             } else {
                 let current = device.brightness()?;
                 println!("{}", output::format_brightness(current));

tests/cli_test.rs

@@ -44,3 +44,15 @@ fn sidetone_without_value_is_read_mode() {
     let result = parse_args(&["corsairctl", "sidetone"]);
     assert!(result.is_ok());
 }
+
+#[test]
+fn led_rejects_above_1000() {
+    let result = parse_args(&["corsairctl", "led", "1001"]);
+    assert!(result.is_err());
+}
+
+#[test]
+fn led_accepts_max() {
+    let result = parse_args(&["corsairctl", "led", "1000"]);
+    assert!(result.is_ok());
+}

tests/output_test.rs

@@ -16,6 +16,30 @@ fn format_battery_charging() {
     assert_eq!(result, "Battery: 50% (Charging)");
 }
 
+#[test]
+fn format_battery_fully_charged() {
+    let result = output::format_battery(100.0, &BatteryStatus::FullyCharged);
+    assert_eq!(result, "Battery: 100% (Full)");
+}
+
+#[test]
+fn format_battery_low() {
+    let result = output::format_battery(10.0, &BatteryStatus::Low);
+    assert_eq!(result, "Battery: 10% (Low)");
+}
+
+#[test]
+fn format_battery_offline() {
+    let result = output::format_battery(0.0, &BatteryStatus::Offline);
+    assert_eq!(result, "Battery: 0% (Offline)");
+}
+
+#[test]
+fn format_battery_unknown() {
+    let result = output::format_battery(50.0, &BatteryStatus::Unknown(0x99));
+    assert_eq!(result, "Battery: 50% (Unknown)");
+}
+
 #[test]
 fn format_brightness_value() {
     let result = output::format_brightness(330);
@@ -125,6 +149,13 @@ fn waybar_json_class_at_boundary_30() {
     assert_eq!(parsed["class"], "warning");
 }
 
+#[test]
+fn waybar_json_class_unknown() {
+    let json_str = output::format_waybar_json(50.0, &BatteryStatus::Unknown(0x99), None);
+    let parsed: serde_json::Value = serde_json::from_str(&json_str).unwrap();
+    assert_eq!(parsed["class"], "unknown");
+}
+
 #[test]
 fn waybar_json_offline() {
     let json_str = output::format_waybar_json(0.0, &BatteryStatus::Offline, None);